Birmingham | ITP-Jan | Roman Sanaye | Sprint 2 | Exercises#1019
Open
RomanSanaye wants to merge 11 commits intoCodeYourFuture:mainfrom
Open
Birmingham | ITP-Jan | Roman Sanaye | Sprint 2 | Exercises#1019RomanSanaye wants to merge 11 commits intoCodeYourFuture:mainfrom
RomanSanaye wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
RomanSanaye
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Mar 22, 2026
Sprint-2/implement/lookup.js
Outdated
Comment on lines
+3
to
+7
| let output = {}; | ||
| for (let pair of input) { | ||
| let key = pair[0]; | ||
| let value = pair[1]; | ||
| output[key] = value; |
Contributor
There was a problem hiding this comment.
output and pair are not going to be reassigned a value, so a better practice is to declare them using const.
We can still modify the array or object assigned to a constant in JS, we just cannot reassign another value to the constant.
Author
There was a problem hiding this comment.
let was replaced with const, and it is a safer option.
cjyuan
added
Reviewed
RomanSanaye
added
the
Needs Review
cjyuan
reviewed
Mar 23, 2026
| let object = [1, 2, 3]; | ||
| let key = "name"; | ||
| expect(contains(object, key)).toEqual(false); | ||
| }); |
Contributor
There was a problem hiding this comment.
In practice, we prepare tests not just to check our own implementation, but also to guard against future modification.
Currently, this incorrectly implemented function could also pass this test:
function contains(object, key) {
if (object === null || typeof object !== "object") {
return false;
}
return Object.prototype.hasOwnProperty.call(object, key);
}
Author
There was a problem hiding this comment.
Thanks for the feedback! I’ve added a test to ensure arrays are rejected even when the key exists, so incorrect implementations will now fail.
cjyuan
removed
the
Needs Review
RomanSanaye
added
the
Needs Review
Contributor
|
All good now. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
totalTillfunction.totalTillfunction.Questions
No questions at this time.